-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added New_in_002 notebook for JS
#1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added New_in_002 notebook for JS
#1024
Conversation
Summary of ChangesHello @Rahul-Lashkari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new JavaScript quickstart notebook designed to help developers explore and utilize the advanced capabilities of the Gemini 1.5 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new JavaScript notebook demonstrating new features in the 002 models, along with an update to the README. The changes are clear and the new notebook is a good JavaScript equivalent of the Python version. I've added one suggestion to improve consistency and maintainability regarding model selection, based on the conventions in other JS notebooks and the repository's style guide.
| */ | ||
|
|
||
| // [CODE STARTS] | ||
| const modelName = "models/gemini-1.5-flash-002"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and consistency with other JavaScript notebooks in this repository (like Get_Started.js), it's recommended to use a model selector parameter. This makes it easier for users to switch between compatible models.1
The SDK typically handles the models/ prefix, so it can be omitted from the model name.
For further consistency, consider renaming modelName to MODEL_ID throughout the script.
const modelName = "gemini-1.5-flash-002"; // @param ["gemini-1.5-flash-002", "gemini-1.5-pro-002"]Style Guide References
Footnotes
-
The style guide recommends using a Colab selector for model selection to improve maintainability. This principle should be applied to the JavaScript notebook format as well. ↩
quickstarts/New_in_002.ipynbnotebookquickstarts-js/README.md