Support viewForRow in grey_pickerColumnSetToValue matcher#1810
Support viewForRow in grey_pickerColumnSetToValue matcher#1810MontakOleg wants to merge 1 commit intogoogle:earlgrey2from
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Can you sign the CLA please? @AlbertWang0116 is to look into merging this in. Albert - feel free to patch and test this internally and then close this contribution once the CLA check is passed. |
|
Sure, SLA should be already signed (as mentioned in Checks section) |
|
@AlbertWang0116, did you have a chance to look at this? |
|
@tirodkar, @AlbertWang0116 hi guys, any news here? |
|
Will patch and let you know. |
Matcher
grey_pickerColumnSetToValueworks fine for UIPicker with delegate that implementspickerView:titleForRow:forComponentORpickerView:attributedTitleForRow:forComponentbut currently does not work for
pickerView:viewForRow:forComponent:reusingView:I believe it should work with viewForRow, because GREYPickerAction works fine with it and there even test that checks it –
PickerViewInteractionTest.testViewForRowDefined.Unfortunately, I think that this test is broken: corresponding
PickerViewControllerimplements both delegate methods –pickerView:titleForRow:forComponentANDpickerView:viewForRow:forComponent:reusingView:, that why test pass.So, I added support for viewForRow in
grey_pickerColumnSetToValuematcher, its just copy-paste fromGREYPickerActionand updated test code.