Replace C++ FFI with memfd exec of embedded nsjail binary#7
Merged
afq984 merged 1 commit intogoogle:mainfrom Apr 5, 2026
Merged
Replace C++ FFI with memfd exec of embedded nsjail binary#7afq984 merged 1 commit intogoogle:mainfrom
afq984 merged 1 commit intogoogle:mainfrom
Conversation
Eliminate the 305-line run_jail.cc C++ FFI layer by embedding the nsjail binary and executing it from a memfd at runtime. - Serialize nsjail config to text proto via prost-reflect - Write config to a memfd (no CLOEXEC, survives exec) - Unpack embedded nsjail binary to a memfd (CLOEXEC) - exec /proc/self/fd/N with -C /dev/fd/M Delete run_jail.cc, run_jail.h, and the cc_library target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the 305-line run_jail.cc C++ FFI layer by embedding the nsjail binary and executing it from a memfd at runtime.
Delete run_jail.cc, run_jail.h, and the cc_library target.