Skip to content

Simplify type cast and remove error handling in protobuf exercise #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randomPoison merged 2 commits into from
Sep 22, 2025
Merged

Simplify type cast and remove error handling in protobuf exercise #2755

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
050c5e1
Simplify type cast and remove error handling in protobuf exercise
randomPoison May 22, 2025
8494b8c
add comment for cast
djmitche Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/lifetimes/exercise.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,7 @@ fn parse_field(data: &[u8]) -> (Field, &[u8]) {
}
WireType::Len => {
let (len, remainder) = parse_varint(remainder);
let len: usize = len.try_into().expect("len not a valid `usize`");
if remainder.len() < len {
panic!("Unexpected EOF");
}
let len = len as usize;
let (value, remainder) = remainder.split_at(len);
(FieldValue::Len(value), remainder)
}
Expand Down