Fix Crubit issue where friend functions declared in a class and then redefined outside are not imported correctly.#793
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Conversation
…redefined outside are not imported correctly. Previously, Crubit would try to import these functions via FriendDeclImporter as children of the class, and might also skip them when processing the outside definition due to canonicalization rules. This change: 1. Skips importing friend declarations in FriendDeclImporter if they are redeclared outside the class. 2. Modifies CanonicalizeDecl to prefer the outside definition as the canonical one if the first declaration was inside a record. This ensures it is imported as a top-level free function. This ensures that friend functions redefined outside are imported as normal top-level free functions. PiperOrigin-RevId: 893141473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Crubit issue where friend functions declared in a class and then redefined outside are not imported correctly.
Previously, Crubit would try to import these functions via FriendDeclImporter as children of the class, and might also skip them when processing the outside definition due to canonicalization rules.
This change:
This ensures that friend functions redefined outside are imported as normal top-level free functions.