Fix nocache short-read tail initialization#60
Open
XavLimSG wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
In nocache mode, Read() can receive a short read from Reader::Read for sparse regions. The unread tail must be zero-filled before we inflate the returned length. This change restores std::ranges::fill(dst, '\0') and adds a regression test that mounts a generated sparse archive with -o nocache,direct_io, reads hole regions, and asserts all returned bytes are NUL.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Summary
In
-o nocachemode,Read()can get a short read fromReader::Readwhen hitting sparse regions. The code shrinksdstto the unread tail and addsdst.size()to the return length, but thestd::ranges::fill(dst, '\0')line that should zero-fill that tail is currently commented out. In release builds (noassert), this means uninitialized buffer contents get returned to the caller.Changes
fuse-archive.cc: Uncommentstd::ranges::fill(dst, '\0')so unread tail bytes are explicitly zeroed before the return length is inflated.test/test.py: AddTestNocacheSparseReadIsZeroFilledregression test that generates a sparse tar archive, mounts with-o nocache,direct_io, reads the sparse region at multiple offsets/sizes, and asserts all returned bytes are NUL.How to test
The new test covers the exact scenario. Run the existing test suite: