Repository navigation
bazel: support _LIBCPP_HARDENING_MODE in setup_configs for LLVM 18+ (#2018) - #2263
Open
jdymitarai wants to merge 1 commit into
Open
jdymitarai wants to merge 1 commit into
jdymitarai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LLVM 18 and newer, libc++ deprecated
_LIBCPP_ENABLE_ASSERTIONSin favor of per-TU hardening modes such as_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE. When compiling with modern Clang toolchains under-Werror, the legacy assertion macro emits a deprecation warning that turns into a compilation failure (#2018).This updates
bazel/setup_configs.shto dynamically detect whether libc++ supports hardening modes via preprocessor probing or toolchain version check, and emits_LIBCPP_HARDENING_MODE_EXTENSIVEfor LLVM 18+ while preserving_LIBCPP_ENABLE_ASSERTIONS=1as a safe fallback on older compilers. Users can also configure an explicit override viaLIBCPP_HARDENING_MODE. In addition,e2e_tests/functional_test.ccis updated so the empty optional dereference test correctly asserts under both legacy assertion and modern hardening configurations.