Have ProviderLookups and MemberInjectorLookups create their dependent bindings early and satisfy delegates later on during initialization#1863
Merged
copybara-service[bot] merged 1 commit intomasterfrom Jan 28, 2025
Conversation
…dent bindings early and satisfy delegates later on during initialization This ensures that other phases can see the jit bindings they create, notably this is important for `OptionalBinder` which queries for bindings using `getExistingBinding` This will allow us to optimize the way `Provider` instances are created in a later change. PiperOrigin-RevId: 720621327
copybara-service
bot
force-pushed
the
test_720284381
branch
from
15706c5 to
2a17feb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have
ProviderLookupsandMemberInjectorLookupscreate their dependent bindings early and satisfy delegates later on during initializationThis ensures that other phases can see the jit bindings they create, notably this is important for
OptionalBinderwhich queries for bindings usinggetExistingBindingThis will allow us to optimize the way
Providerinstances are created in a later change.