Allow factories to customize their generated Providers#1864
Merged
copybara-service[bot] merged 1 commit intomasterfrom Jan 29, 2025
Merged
Allow factories to customize their generated Providers#1864copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_714766545
branch
from
0cff5c0 to
35a1b49
Compare
This enables a few optimizations - A number of implementations can avoid `InternalContext` overheads addressing #1802 - `ConstantBindings`, one time bindings like `Initializable` and `@Singleton` bound values, and a number of multibinder bindings in particular. - We can leverage the cache within `BindingImpl` to share provider instances. The tricky part is about multibindings, which have complex multi-phase initialization semantics, so we need to be defensive about `makeProvider` getting called prior to being initialized. To help manage this I * reordered the `LookupProcessor` to run _after_ multibinders. - The comment justifying its current location in initialization is obsolete since multibinders were rewritten to be 'native'. - This ensures lookups get optimized providers! * made the `SyntheticProviderFactory` allocate its delegate lazily. * make `OptionalBinder` explicitly initialize their delegate bindings and also be defensive against recursive and duplicate initialization. This is necessary to force initialization to be correct when our `getExistingBinding` query ends up delegating to another multibinder. * be defensive about initialization failing to complete due to errors PiperOrigin-RevId: 721080468
copybara-service
bot
force-pushed
the
test_714766545
branch
from
35a1b49 to
9e4df6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow factories to customize their generated Providers
This enables a few optimizations
InternalContextoverheads addressing High memory consumption to obtain a Singleton instance via Injector or Provider #1802ConstantBindings, one time bindings likeInitializableand@Singletonbound values, and a number of multibinder bindings in particular.BindingImplto share provider instances.The tricky part is about multibindings, which have complex multi-phase initialization semantics, so we need to be defensive about
makeProvidergetting called prior to being initialized. To help manage this ILookupProcessorto run after multibinders.SyntheticProviderFactoryallocate its delegate lazily.OptionalBinderexplicitly initialize their delegate bindings and also be defensive against recursive and duplicate initialization. This is necessary to force initialization to be correct when ourgetExistingBindingquery ends up delegating to another multibinder.