Use absl::string_view for texture callback functions#541
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Use absl::string_view for texture callback functions#541copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_885362825
branch
3 times, most recently
from
9c1194c to
6369f31
Compare
Replace usage of `std::map` in some of these callback functions with `absl::flat_hash_map` as well, since the latter allows for heterogeneous lookup, reducing amount of conversions needed from `string_view` to `string`. PiperOrigin-RevId: 885362825
copybara-service
bot
force-pushed
the
test_885362825
branch
from
6369f31 to
d7162c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use absl::string_view for texture callback functions
Replace usage of
std::mapin some of these callback functions withabsl::flat_hash_mapas well, since the latter allows for heterogeneous lookup, reducing amount of conversions needed fromstring_viewtostring.