Lazily compute fully qualified Java annotation names#2860
Open
Lazily compute fully qualified Java annotation names#2860
Conversation
jaschdoc
force-pushed
the
psi-handle-java-shortnames
branch
from
b001c9c to
be3347a
Compare
bcorso
reviewed
Apr 8, 2026
kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/PsiResolutionStrategy.kt
Outdated
Show resolved
Hide resolved
bcorso
reviewed
Apr 8, 2026
kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/PsiResolutionStrategy.kt
Outdated
Show resolved
Hide resolved
bcorso
reviewed
Apr 8, 2026
kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/PsiResolutionStrategy.kt
Outdated
Show resolved
Hide resolved
jaschdoc
force-pushed
the
psi-handle-java-shortnames
branch
2 times, most recently
from
513dd08 to
89e8477
Compare
bcorso
reviewed
Apr 9, 2026
kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/PsiResolutionStrategy.kt
Outdated
Show resolved
Hide resolved
bcorso
reviewed
Apr 9, 2026
kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/PsiResolutionStrategy.kt
Outdated
Show resolved
Hide resolved
bcorso
reviewed
Apr 9, 2026
kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/PsiResolutionStrategy.kt
Show resolved
Hide resolved
bcorso
approved these changes
Apr 9, 2026
Collaborator
bcorso
left a comment
bcorso
left a comment
There was a problem hiding this comment.
Left a few comments, but overall LGTM. Thanks!
ting-yuan
previously approved these changes
Apr 9, 2026
jaschdoc
force-pushed
the
psi-handle-java-shortnames
branch
from
12ba373 to
2c59c88
Compare
jaschdoc
force-pushed
the
psi-handle-java-shortnames
branch
from
2c59c88 to
23305a3
Compare
troelsbjerre
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2847
Related to #2816