Draft
Conversation
🎨 Perfetto UI Builds
|
ea8f54f to
1e03163
Compare
Change-Id: I2b8db9ddb3509487339434f19df35f29eba4774c
1e03163 to
ea419d8
Compare
Member
|
Small drive-by since I saw this CL. The existing minimap on non-Android traces is really ugly. Espeically if it's a very simple trace and there's only a single track. In that case the whole minimap would just be a black bar. If it's easy then can we please consider doing something nicer (especially if we can minimize the vertical space used) or even hide the minimap entirely is perfectly OK - for simple traces like that, you don't need much help navigating it. |
Member
|
Please don't consider the above blocking, it was only something I was thinking about discussing with you at some point anyway but since you're here, thought it would be good to share. If it's too much work or it becomes a rabbit hole, I'd much rather some improvement lands! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.