perfetto: heap_profile: extract process_trace, refactor roll-prebuilts#5039
Open
LalitMaganti wants to merge 1 commit intomainfrom
Open
perfetto: heap_profile: extract process_trace, refactor roll-prebuilts#5039LalitMaganti wants to merge 1 commit intomainfrom
LalitMaganti wants to merge 1 commit intomainfrom
Conversation
LalitMaganti
force-pushed
the
dev/lalitm/heap-profile-1
branch
from
8339964 to
7034d73
Compare
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/heap-profile-1
branch
2 times, most recently
from
38fe36c to
70e19bc
Compare
Extract the traceconv/symbolize/deobfuscate/gzip logic into a reusable process_trace() helper. The Android path now calls this helper, with no change in behaviour. This makes the function available to future callers (e.g. a Linux local-profiling path). Also refactor tools/release/roll-prebuilts: update_manifest() now accepts a full spec dict (matching the MANIFESTS_TO_UPDATE entries) and make_manifest() gains an optional file_name parameter so the output filename can differ from the GN target name.
LalitMaganti
force-pushed
the
dev/lalitm/heap-profile-1
branch
from
70e19bc to
76b8758
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the traceconv/symbolize/deobfuscate/gzip logic into a
reusable process_trace() helper. The Android path now calls this
helper, with no change in behaviour. This makes the function
available to future callers (e.g. a Linux local-profiling path).
Also refactor tools/release/roll-prebuilts: update_manifest() now
accepts a full spec dict (matching the MANIFESTS_TO_UPDATE entries)
and make_manifest() gains an optional file_name parameter so the
output filename can differ from the GN target name.
This is a pure refactoring change with no functional diff.