Depend on AGP API artifact only #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using AGP internal APIs in this plugin, we have fully migrated to `AndroidComponentsExtension`.
Goooler
commented
Sep 5, 2024
| private fun check(vararg keyValues: Pair<String, String>) { | ||
| keyValues.forEach { (key, value) -> | ||
| Assert.assertEquals(value, placeholders[key]) | ||
| verify(variant).buildConfigField("String", key, value.addParenthesisIfNeeded()) |
There was a problem hiding this comment.
This assertion step looks wrong. I guess you want to assert that the key-paired buildConfigField exists?
Goooler
commented
Sep 5, 2024
| private fun checkKeysNotIn(vararg keys: String) { | ||
| keys.forEach { | ||
| Assert.assertFalse(placeholders.containsKey(it)) | ||
| assertTrue(variant.manifestPlaceholders.getting(it).orNull == null) |
There was a problem hiding this comment.
We can use assertFalse or assertNull here if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using AGP internal APIs in this plugin, we have fully migrated to
AndroidComponentsExtension.