Skip to content

Swap some for-loops for lambdas in stdlib. #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −10
Draft

Swap some for-loops for lambdas in stdlib. #4086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions xls/dslx/stdlib/std.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,7 @@ fn convert_to_bits_msb0_test() {
//
// This variant puts the LSb (least significant bit) of the word at index 0 in
// the resulting array.
pub fn convert_to_bools_lsb0<N: u32>(x: uN[N]) -> bool[N] {
for (idx, partial): (u32, bool[N]) in 0..N {
update(partial, idx, x[idx+:bool])
}([false, ...])
}
pub fn convert_to_bools_lsb0<N: u32>(x: uN[N]) -> bool[N] { map(0..N, |idx| x[idx+:bool]) }

#[test]
fn convert_to_bools_lsb0_test() {
Expand Down Expand Up @@ -613,11 +609,8 @@ fn convert_to_from_bools(x: u4) -> bool {
// ultimately discarded from the unselected match arm.
pub fn find_index<BITS: u32, ELEMS: u32>(array: uN[BITS][ELEMS], x: uN[BITS]) -> (bool, u32) {
// Compute all the positions that are equal to our target.
let bools: bool[ELEMS] = for (i, accum) in 0..ELEMS {
update(accum, i, array[i] == x)
}([false, ...]);

let x: uN[ELEMS] = convert_to_bits_msb0(bools);
let bools = map(0..ELEMS, |i| array[i] == x);
let x = convert_to_bits_msb0(bools);
let index = clz(x);
let found: bool = or_reduce(x);
(found, if found { index as u32 } else { 0 })
Expand Down
Loading