Add design document for division simplification in XLS.#4091
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Add design document for division simplification in XLS.#4091copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This document outlines a design for simplifying division operations where the divisor takes a small set of values, using PartialInfoQueryEngine to analyze possible divisor values. The design covers cases where divisors are powers of two, general constants, or a hybrid mix, and suggests implementation in three phases. Divisions by powers of two can be simplified to either a shift-by-encode or to division by constants (which will later be reduced to shifts by constants), while divisions by general values can be simplified to division by constants (which will later be reduced to multiply-and-shift form). PiperOrigin-RevId: 896714607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add design document for division simplification in XLS.
This document outlines a design for simplifying division operations where the divisor takes a small set of values, using PartialInfoQueryEngine to analyze possible divisor values. The design covers cases where divisors are powers of two, general constants, or a hybrid mix, and suggests implementation in three phases. Divisions by powers of two can be simplified to either a shift-by-encode or to division by constants (which will later be reduced to shifts by constants), while divisions by general values can be simplified to division by constants (which will later be reduced to multiply-and-shift form).