-
Notifications
You must be signed in to change notification settings - Fork 553
feat: API regeneration: release-2026-01-26.09-02-39 #3114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest API discovery documents across a wide array of Google Cloud services. The updates bring new functionalities, improve existing API definitions for better developer experience, and ensure consistency in terminology and resource management. The changes reflect ongoing evolution in Google Cloud's offerings, from core infrastructure to specialized services like AI and security. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily consists of API regeneration changes, including new fields, schemas, and updated descriptions across various services. There are also updates to copyright years and package versions in the generated C# client libraries. Most changes are minor descriptive improvements or additions of new API surface. However, there are a few notable changes that impact API contracts and usage, which are highlighted in the specific review comments.
| "global": { | ||
| "resources": { | ||
| "operations": { | ||
| "methods": { | ||
| "cancel": { | ||
| "description": "Starts asynchronous cancellation on a long-running operation. The server makes a best effort to cancel the operation, but success is not guaranteed. If the server doesn't support this method, it returns `google.rpc.Code.UNIMPLEMENTED`. Clients can use Operations.GetOperation or other methods to check whether the cancellation succeeded or whether the operation completed despite cancellation. On successful cancellation, the operation is not deleted; instead, it becomes an operation with an Operation.error value with a google.rpc.Status.code of `1`, corresponding to `Code.CANCELLED`.", | ||
| "flatPath": "v1/organizations/{organizationsId}/locations/global/operations/{operationsId}:cancel", | ||
| "httpMethod": "POST", | ||
| "id": "networkmanagement.organizations.locations.global.operations.cancel", | ||
| "parameterOrder": [ | ||
| "name" | ||
| ], | ||
| "parameters": { | ||
| "name": { | ||
| "description": "The name of the operation resource to be cancelled.", | ||
| "location": "path", | ||
| "pattern": "^organizations/[^/]+/locations/global/operations/[^/]+$", | ||
| "required": true, | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "path": "v1/{+name}:cancel", | ||
| "request": { | ||
| "$ref": "CancelOperationRequest" | ||
| }, | ||
| "response": { | ||
| "$ref": "Empty" | ||
| }, | ||
| "scopes": [ | ||
| "https://www.googleapis.com/auth/cloud-platform" | ||
| ] | ||
| }, | ||
| "pageSize": { | ||
| "description": "The standard list page size.", | ||
| "format": "int32", | ||
| "location": "query", | ||
| "type": "integer" | ||
| "delete": { | ||
| "description": "Deletes a long-running operation. This method indicates that the client is no longer interested in the operation result. It does not cancel the operation. If the server doesn't support this method, it returns `google.rpc.Code.UNIMPLEMENTED`.", | ||
| "flatPath": "v1/organizations/{organizationsId}/locations/global/operations/{operationsId}", | ||
| "httpMethod": "DELETE", | ||
| "id": "networkmanagement.organizations.locations.global.operations.delete", | ||
| "parameterOrder": [ | ||
| "name" | ||
| ], | ||
| "parameters": { | ||
| "name": { | ||
| "description": "The name of the operation resource to be deleted.", | ||
| "location": "path", | ||
| "pattern": "^organizations/[^/]+/locations/global/operations/[^/]+$", | ||
| "required": true, | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "path": "v1/{+name}", | ||
| "response": { | ||
| "$ref": "Empty" | ||
| }, | ||
| "scopes": [ | ||
| "https://www.googleapis.com/auth/cloud-platform" | ||
| ] | ||
| }, | ||
| "pageToken": { | ||
| "description": "The standard list page token.", | ||
| "location": "query", | ||
| "type": "string" | ||
| "get": { | ||
| "description": "Gets the latest state of a long-running operation. Clients can use this method to poll the operation result at intervals as recommended by the API service.", | ||
| "flatPath": "v1/organizations/{organizationsId}/locations/global/operations/{operationsId}", | ||
| "httpMethod": "GET", | ||
| "id": "networkmanagement.organizations.locations.global.operations.get", | ||
| "parameterOrder": [ | ||
| "name" | ||
| ], | ||
| "parameters": { | ||
| "name": { | ||
| "description": "The name of the operation resource.", | ||
| "location": "path", | ||
| "pattern": "^organizations/[^/]+/locations/global/operations/[^/]+$", | ||
| "required": true, | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "path": "v1/{+name}", | ||
| "response": { | ||
| "$ref": "Operation" | ||
| }, | ||
| "scopes": [ | ||
| "https://www.googleapis.com/auth/cloud-platform" | ||
| ] | ||
| }, | ||
| "returnPartialSuccess": { | ||
| "description": "When set to `true`, operations that are reachable are returned as normal, and those that are unreachable are returned in the ListOperationsResponse.unreachable field. This can only be `true` when reading across collections. For example, when `parent` is set to `\"projects/example/locations/-\"`. This field is not supported by default and will result in an `UNIMPLEMENTED` error if set unless explicitly documented otherwise in service or product specific documentation.", | ||
| "location": "query", | ||
| "type": "boolean" | ||
| "list": { | ||
| "description": "Lists operations that match the specified filter in the request. If the server doesn't support this method, it returns `UNIMPLEMENTED`.", | ||
| "flatPath": "v1/organizations/{organizationsId}/locations/global/operations", | ||
| "httpMethod": "GET", | ||
| "id": "networkmanagement.organizations.locations.global.operations.list", | ||
| "parameterOrder": [ | ||
| "name" | ||
| ], | ||
| "parameters": { | ||
| "filter": { | ||
| "description": "The standard list filter.", | ||
| "location": "query", | ||
| "type": "string" | ||
| }, | ||
| "name": { | ||
| "description": "The name of the operation's parent resource.", | ||
| "location": "path", | ||
| "pattern": "^organizations/[^/]+/locations/global$", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| "pageSize": { | ||
| "description": "The standard list page size.", | ||
| "format": "int32", | ||
| "location": "query", | ||
| "type": "integer" | ||
| }, | ||
| "pageToken": { | ||
| "description": "The standard list page token.", | ||
| "location": "query", | ||
| "type": "string" | ||
| }, | ||
| "returnPartialSuccess": { | ||
| "description": "When set to `true`, operations that are reachable are returned as normal, and those that are unreachable are returned in the ListOperationsResponse.unreachable field. This can only be `true` when reading across collections. For example, when `parent` is set to `\"projects/example/locations/-\"`. This field is not supported by default and will result in an `UNIMPLEMENTED` error if set unless explicitly documented otherwise in service or product specific documentation.", | ||
| "location": "query", | ||
| "type": "boolean" | ||
| } | ||
| }, | ||
| "path": "v1/{+name}/operations", | ||
| "response": { | ||
| "$ref": "ListOperationsResponse" | ||
| }, | ||
| "scopes": [ | ||
| "https://www.googleapis.com/auth/cloud-platform" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resource path for operations has been changed from being location-specific (organizations/{organizationsId}/locations/{locationsId}/operations) to a global scope (organizations/{organizationsId}/locations/global/operations). This is a significant change in the API's resource hierarchy and could be a breaking change for existing clients that expect operations to be nested under a specific location. It's important to ensure this change is intentional and communicated clearly to API consumers.
| /// <summary> | ||
| /// Optional. The peer database name to switch over to. Required for cross-region standby, and must be omitted | ||
| /// for in-region Data Guard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PeerAutonomousDatabase field in SwitchoverAutonomousDatabaseRequest has changed from Required to Optional, with additional conditions for when it is required or must be omitted. This is a breaking change for clients that might have relied on it always being required. Ensure this change is well-documented and communicated to API consumers.
| /// <summary> | ||
| /// Optional. The peer database name to fail over to. Required for cross-region standby, and must be omitted for | ||
| /// in-region Data Guard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PeerAutonomousDatabase field in FailoverAutonomousDatabaseRequest has changed from Required to Optional, with additional conditions for when it is required or must be omitted. This is a breaking change for clients that might have relied on it always being required. Ensure this change is well-documented and communicated to API consumers.
| Global = new GlobalResource(service); | ||
| VpcFlowLogsConfigs = new VpcFlowLogsConfigsResource(service); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Operations resource has been moved under a Global sub-resource. This refactoring changes the API path for operations, which could lead to breaking changes for existing client code. It's crucial to ensure that this change is intentional and that client libraries are updated accordingly to reflect the new hierarchy.
| "description": "Optional. The peer database name to switch over to. Required for cross-region standby, and must be omitted for in-region Data Guard.", | ||
| "type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The peerAutonomousDatabase field in SwitchoverAutonomousDatabaseRequest has changed from Required to Optional, with additional conditions for when it is required or must be omitted. This is a breaking change for clients that might have relied on it always being required. Ensure this change is well-documented and communicated to API consumers.
| /// <summary>Optional. Immutable. The private endpoint label for the Autonomous Database.</summary> | ||
| [Newtonsoft.Json.JsonPropertyAttribute("privateEndpointLabel")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// <summary>Optional. Immutable. The ID of the Oracle Cloud Infrastructure vault secret.</summary> | ||
| [Newtonsoft.Json.JsonPropertyAttribute("secretId")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// <summary>Optional. Immutable. The ID of the Oracle Cloud Infrastructure vault.</summary> | ||
| [Newtonsoft.Json.JsonPropertyAttribute("vaultId")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "description": "Optional. Immutable. The subnet CIDR range for the Autonomous Database.", | ||
| "type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "description": "Optional. Immutable. The password for the default ADMIN user.", | ||
| "type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this PR will be published to Nuget on the next release cycle.