Skip to content

Conversation

diegomarquezp
Copy link
Contributor

These files are only referenced in a test and the actual files don't exist in this repository. The jars and dependencies are all managed by the api-client BOM

def testCheckDependenciesExist(self):
# Test that the files in requires actually exist.
nonexistent = {}
for path in self.WalkFileTree(r'features\.json$'):
# Skip this check for 'default' versions of language surface. Those don't
# get used in the service, so they don't need dependencies
if 'default' in path:
continue
# Skip this check for test files.
if path.find('/testdata/') >= 0:
continue
json_data = self.LoadJsonFile(path, True)
if not json_data:
raise Exception('cannot parse json: %s' % path)
features_dir = os.path.dirname(path)
paths = []
for r in json_data.get('requires', []):
for f in r.get('files', []):
file_path = f.get('path')
if file_path:
p = os.path.join(features_dir, 'dependencies', file_path)
paths.append(p)

These files are only referenced in a test and the actual files don't exist in this repository. The jars and dependencies are all managed by the api-client BOM

https://github.com/googleapis/google-api-java-client-services/blob/4ba8ff880ea4acfe490510917941a82854e47fd3/generator/tests/configuration_test.py#L125-L148
@diegomarquezp diegomarquezp requested a review from a team as a code owner August 22, 2025 20:31
@lqiu96
Copy link
Member

lqiu96 commented Aug 22, 2025

Do you know if testCheckDependenciesExist would fail? Would it make sense to remove this test?

I'm not too sure, but it also looks like the generator's tests aren't being run? Do we have a CI job that runs the python tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants