fix(storage): URL template in open_object - #6724
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the URL template for the BidiStreamingRead RPC method in src/storage/src/storage/transport.rs from "/upload/storage/v1/b/{bucket}/o" to "/storage/v1/b/{bucket}/o/{object}". It also adds a new integration test open_object_url_template to verify that the telemetry attributes and client request spans are correctly recorded. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6724 +/- ##
=======================================
Coverage 96.66% 96.67%
=======================================
Files 308 308
Lines 97778 97778
=======================================
+ Hits 94519 94527 +8
+ Misses 3259 3251 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
coryan
marked this pull request as ready for review
September 7, 2026 17:50
dbolduc
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6673