Skip to content

fix(storage): URL template in open_object - #6724

Merged
coryan merged 3 commits into
googleapis:mainfrom
coryan:fix-bug-6673
Sep 7, 2026
Merged

fix(storage): URL template in open_object#6724
coryan merged 3 commits into
googleapis:mainfrom
coryan:fix-bug-6673

Conversation

@coryan

@coryan coryan commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #6673

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Sep 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the URL template for the BidiStreamingRead RPC method in src/storage/src/storage/transport.rs from "/upload/storage/v1/b/{bucket}/o" to "/storage/v1/b/{bucket}/o/{object}". It also adds a new integration test open_object_url_template to verify that the telemetry attributes and client request spans are correctly recorded. There are no review comments, and I have no feedback to provide.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.67%. Comparing base (86c2a65) to head (ce57a86).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6724   +/-   ##
=======================================
  Coverage   96.66%   96.67%           
=======================================
  Files         308      308           
  Lines       97778    97778           
=======================================
+ Hits        94519    94527    +8     
+ Misses       3259     3251    -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan
coryan marked this pull request as ready for review September 7, 2026 17:50
@coryan
coryan requested review from a team as code owners September 7, 2026 17:50
@coryan
coryan merged commit 9953b09 into googleapis:main Sep 7, 2026
42 checks passed
@coryan
coryan deleted the fix-bug-6673 branch September 7, 2026 18:04
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect URL template in Storage open_object request telemetry

2 participants