fix(pubsub): avoid max lease overflow errors - #6727
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a maximum lease duration clamp of 1000 years to prevent overflow errors when setting the maximum lease, and adds a corresponding unit test. The feedback suggests reducing this limit to 100 years because a 1000-year duration can still cause overflow panics when added to an Instant on platforms where Instant is represented as a 64-bit integer of nanoseconds.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6727 +/- ##
==========================================
- Coverage 96.72% 96.71% -0.01%
==========================================
Files 313 313
Lines 101266 101275 +9
==========================================
+ Hits 97948 97949 +1
- Misses 3318 3326 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
marked this pull request as ready for review
September 7, 2026 18:01
coryan
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6721