Skip to content

fix: mistyping of langchain tools causing mypy errors #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jan 12, 2026
+10 −12
Merged

fix: mistyping of langchain tools causing mypy errors #6250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions vertexai/agent_engines/templates/langchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
Iterable,
Mapping,
Optional,
Sequence,
Union,
)

Expand All @@ -46,9 +45,9 @@
try:
from langchain_google_vertexai.functions_utils import _ToolsType

_ToolLike = _ToolsType
_ToolsType = _ToolsType
except ImportError:
_ToolLike = Any
_ToolsType = Any

try:
from opentelemetry.sdk import trace
Expand Down Expand Up @@ -116,7 +115,7 @@ def _default_runnable_builder(
model: "BaseLanguageModel",
*,
system_instruction: Optional[str] = None,
tools: Optional[Sequence["_ToolLike"]] = None,
tools: Optional["_ToolsType"] = None,
prompt: Optional["RunnableSerializable"] = None,
output_parser: Optional["RunnableSerializable"] = None,
chat_history: Optional["GetSessionHistoryCallable"] = None,
Expand Down Expand Up @@ -320,7 +319,7 @@ def _validate_callable_parameters_are_annotated(callable: Callable):
)


def _validate_tools(tools: Sequence["_ToolLike"]):
def _validate_tools(tools: "_ToolsType"):
"""Validates that the tools are usable for tool calling."""
for tool in tools:
if isinstance(tool, Callable):
Expand Down Expand Up @@ -370,7 +369,7 @@ def __init__(
*,
system_instruction: Optional[str] = None,
prompt: Optional["RunnableSerializable"] = None,
tools: Optional[Sequence["_ToolLike"]] = None,
tools: Optional["_ToolsType"] = None,
output_parser: Optional["RunnableSerializable"] = None,
chat_history: Optional["GetSessionHistoryCallable"] = None,
model_kwargs: Optional[Mapping[str, Any]] = None,
Expand Down
11 changes: 5 additions & 6 deletions vertexai/preview/reasoning_engines/templates/langchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
Iterable,
Mapping,
Optional,
Sequence,
Union,
)

Expand All @@ -46,9 +45,9 @@
try:
from langchain_google_vertexai.functions_utils import _ToolsType

_ToolLike = _ToolsType
_ToolsType = _ToolsType
except ImportError:
_ToolLike = Any
_ToolsType = Any

try:
from opentelemetry.sdk import trace
Expand Down Expand Up @@ -116,7 +115,7 @@ def _default_runnable_builder(
model: "BaseLanguageModel",
*,
system_instruction: Optional[str] = None,
tools: Optional[Sequence["_ToolLike"]] = None,
tools: Optional["_ToolsType"] = None,
prompt: Optional["RunnableSerializable"] = None,
output_parser: Optional["RunnableSerializable"] = None,
chat_history: Optional["GetSessionHistoryCallable"] = None,
Expand Down Expand Up @@ -234,7 +233,7 @@ def _validate_callable_parameters_are_annotated(callable: Callable):
)


def _validate_tools(tools: Sequence["_ToolLike"]):
def _validate_tools(tools: "_ToolsType"):
"""Validates that the tools are usable for tool calling."""
for tool in tools:
if isinstance(tool, Callable):
Expand Down Expand Up @@ -284,7 +283,7 @@ def __init__(
*,
system_instruction: Optional[str] = None,
prompt: Optional["RunnableSerializable"] = None,
tools: Optional[Sequence["_ToolLike"]] = None,
tools: Optional["_ToolsType"] = None,
output_parser: Optional["RunnableSerializable"] = None,
chat_history: Optional["GetSessionHistoryCallable"] = None,
model_kwargs: Optional[Mapping[str, Any]] = None,
Expand Down
Loading