Skip to content
This repository was archived by the owner on Apr 23, 2021. It is now read-only.

Add staging support.#47

Open
cscatolini wants to merge 3 commits intogooglearchive:masterfrom
topfreegames:master
Open

Add staging support.#47
cscatolini wants to merge 3 commits intogooglearchive:masterfrom
topfreegames:master

Conversation

@cscatolini
Copy link
Copy Markdown

This PR introduces an isProduction flag to allow switching between production and staging xmpp addresses.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cscatolini
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 6, 2017
@appleboy
Copy link
Copy Markdown
Contributor

appleboy commented Jan 6, 2017

This change will break this package which anybody uses currently. You need to create another function to change staging or production mode.

@cscatolini
Copy link
Copy Markdown
Author

cscatolini commented Jan 6, 2017

@appleboy you are absolutely correct, I've sent another commit fixing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants