Conversation
Member
Author
|
Offline review by @haimkastner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
Added documentation to the
definitionspackageRemoved some dead structs and code
Fixed an inconsistency in
CHANGELOG.mdImportant note:
This is technically a minor breaking change as several public items were removed.
That said, these structures are entirely unused and should not be implicated in any consumer code.
A list of removals:
EnumValidator(struct)EnumValidators(fieldinModelsstruct)OrderedIdent(struct)EnsureValidHttpVerb(function)A major version release would be far more disruptive here.