[Page] Update: Adjust SPX tutorial page text and color#3169
[Page] Update: Adjust SPX tutorial page text and color#3169hejiaping-pipi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies layout properties and content in ui/pages/spx/tutorial.pen, including adjustments to coordinates, container widths, and the addition of descendant styles. Feedback was provided regarding a likely typo in the "content" field and the use of overly precise floating-point values for dimensions and positions, which should be rounded to integers to avoid rendering artifacts and improve readability.
| "x": 0.07806559948336479, | ||
| "y": 0, | ||
| "content": "All Tutorials" | ||
| "content": "hrllo" |
| "name": "Course container", | ||
| "clip": true, | ||
| "width": 988, | ||
| "width": 987.9219405682865, |
| "type": "ref", | ||
| "ref": "P:WiWwa", | ||
| "x": 0.0001975079347187812, | ||
| "x": 0.00018589109107464467, |
There was a problem hiding this comment.
Code Review
This PR modifies a single UI layout file (ui/pages/spx/tutorial.pen). The descendants color override block is structurally correct and consistent with the codebase. Three issues were found:
| Severity | Issue |
|---|---|
| 🔴 Critical | "hrllo" is an apparent typo — visible user-facing heading text |
| 🟡 Minor | Fractional width creates a ~0.08px inconsistency with sibling frames |
| ⚪ Nit | Sub-pixel x-offset noise should be 0 |
| "x": 0.07806559948336479, | ||
| "y": 0, | ||
| "content": "All Tutorials" | ||
| "content": "hrllo" |
There was a problem hiding this comment.
Critical: Typo in user-facing heading text.
"hrllo" is not a valid word and appears to be an accidental keystroke (likely mistyped "hello") committed while the design tool had focus. The original value "All Tutorials" is the correct section heading and matches the corresponding Vue component. This string renders directly on the tutorial page and must be corrected before merging.
| "name": "Course container", | ||
| "clip": true, | ||
| "width": 988, | ||
| "width": 987.9219405682865, |
There was a problem hiding this comment.
Minor: Fractional width is inconsistent with child frames.
987.9219405682865 appears to be floating-point drift from a design tool drag operation. The sibling "Course item g" frames inside this container all declare "width": 988. The container is now ~0.08px narrower than its children, which is a latent clip risk given "clip": true is set on this frame. Rounding back to 988 keeps it consistent with its children and the original intent.
| "type": "ref", | ||
| "ref": "P:WiWwa", | ||
| "x": 0.0001975079347187812, | ||
| "x": 0.00018589109107464467, |
There was a problem hiding this comment.
Nit: Sub-pixel x-offset is floating-point noise.
Both the old value (0.0001975...) and the new value (0.00018589...) are sub-pixel and effectively zero. This is tool-generated noise that accumulates in diffs and obscures real positional changes. Consider setting this to 0.
Issue
N/A
Background
Update the SPX tutorial page design to adjust the displayed title text and refine the visual color treatment.
Changes
All Tutorialstohrllo$P:blue600fill to the related tutorial elementScope
ui/pages/spx/tutorial.penDesign System Impact