Skip to content

[Page] Update: Adjust SPX tutorial page text and color#3169

Open
hejiaping-pipi wants to merge 1 commit into
goplus:uifrom
hejiaping-pipi:hepipi
Open

[Page] Update: Adjust SPX tutorial page text and color#3169
hejiaping-pipi wants to merge 1 commit into
goplus:uifrom
hejiaping-pipi:hepipi

Conversation

@hejiaping-pipi
Copy link
Copy Markdown

Issue

N/A

Background

Update the SPX tutorial page design to adjust the displayed title text and refine the visual color treatment.

Changes

  • Updated the tutorial page title text from All Tutorials to hrllo
  • Applied $P:blue600 fill to the related tutorial element
  • Adjusted the tutorial page layout positioning and course container width slightly

Scope

  • SPX tutorial page: ui/pages/spx/tutorial.pen

Design System Impact

  • Yes
  • No

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies layout properties and content in ui/pages/spx/tutorial.pen, including adjustments to coordinates, container widths, and the addition of descendant styles. Feedback was provided regarding a likely typo in the "content" field and the use of overly precise floating-point values for dimensions and positions, which should be rounded to integers to avoid rendering artifacts and improve readability.

Comment thread ui/pages/spx/tutorial.pen
"x": 0.07806559948336479,
"y": 0,
"content": "All Tutorials"
"content": "hrllo"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The string "hrllo" appears to be a typo or a placeholder. It is recommended to use a meaningful title such as "All Tutorials" or a localized string key if supported by the format.

                      "content": "All Tutorials"

Comment thread ui/pages/spx/tutorial.pen
"name": "Course container",
"clip": true,
"width": 988,
"width": 987.9219405682865,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The width value 987.9219405682865 is overly precise. Using non-integer values for container widths can lead to sub-pixel rendering artifacts. It is recommended to use an integer value like 988.

                      "width": 988,

Comment thread ui/pages/spx/tutorial.pen
"type": "ref",
"ref": "P:WiWwa",
"x": 0.0001975079347187812,
"x": 0.00018589109107464467,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The coordinate value 0.00018589109107464467 is extremely precise and practically zero. Consider using an integer like 0 to improve readability and avoid potential floating-point precision issues in layout calculations.

          "x": 0,

Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR modifies a single UI layout file (ui/pages/spx/tutorial.pen). The descendants color override block is structurally correct and consistent with the codebase. Three issues were found:

Severity Issue
🔴 Critical "hrllo" is an apparent typo — visible user-facing heading text
🟡 Minor Fractional width creates a ~0.08px inconsistency with sibling frames
⚪ Nit Sub-pixel x-offset noise should be 0

Comment thread ui/pages/spx/tutorial.pen
"x": 0.07806559948336479,
"y": 0,
"content": "All Tutorials"
"content": "hrllo"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical: Typo in user-facing heading text.

"hrllo" is not a valid word and appears to be an accidental keystroke (likely mistyped "hello") committed while the design tool had focus. The original value "All Tutorials" is the correct section heading and matches the corresponding Vue component. This string renders directly on the tutorial page and must be corrected before merging.

Comment thread ui/pages/spx/tutorial.pen
"name": "Course container",
"clip": true,
"width": 988,
"width": 987.9219405682865,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Fractional width is inconsistent with child frames.

987.9219405682865 appears to be floating-point drift from a design tool drag operation. The sibling "Course item g" frames inside this container all declare "width": 988. The container is now ~0.08px narrower than its children, which is a latent clip risk given "clip": true is set on this frame. Rounding back to 988 keeps it consistent with its children and the original intent.

Comment thread ui/pages/spx/tutorial.pen
"type": "ref",
"ref": "P:WiWwa",
"x": 0.0001975079347187812,
"x": 0.00018589109107464467,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Sub-pixel x-offset is floating-point noise.

Both the old value (0.0001975...) and the new value (0.00018589...) are sub-pixel and effectively zero. This is tool-generated noise that accumulates in diffs and obscures real positional changes. Consider setting this to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant