refactor: drop redundant int64 in newrandomgenerator#1256
Merged
zhenghaoz merged 1 commit intogorse-io:masterfrom Apr 30, 2026
Merged
refactor: drop redundant int64 in newrandomgenerator#1256zhenghaoz merged 1 commit intogorse-io:masterfrom
zhenghaoz merged 1 commit intogorse-io:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
- Coverage 72.95% 72.91% -0.04%
==========================================
Files 91 91
Lines 16720 16720
==========================================
- Hits 12198 12192 -6
- Misses 3278 3283 +5
- Partials 1244 1245 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description:
remove redundant int64(seed) cast in NewRandomGenerator
seed is already int64 from the function signature