Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

[WIP] pancake-svg package enhancement #103

Open
mikey0000 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] pancake-svg package enhancement #103

mikey0000 wants to merge 4 commits into from

Conversation

@mikey0000
Copy link

@mikey0000 mikey0000 commented Feb 28, 2019

make a svg plugin.

Needs a bit of tidying up to get all the promise ducks in a row but does work.
not a ton of extra configuration but is a good standard start with png fallback images being created as well.

@mikey0000 mikey0000 mentioned this pull request Feb 28, 2019
Open
@mikey0000 mikey0000 changed the base branch from master to develop February 28, 2019 02:36
@mikey0000 mikey0000 force-pushed the feature/pancake-svg-enhancement branch from 2088d8f to 4cd876c Compare February 28, 2019 02:39
@azerella azerella self-requested a review February 28, 2019 03:05
@azerella azerella added enhancement New feature or request. module: pancake-svg An issue or pull request related to pancake-svg. labels Feb 28, 2019
dominikwilkowski
dominikwilkowski reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@dominikwilkowski dominikwilkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start

azerella
azerella reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@azerella azerella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mikey0000! The SVG updates look pretty good, obviously as this is such a large change we're going to have to go through everything so it might take a bit of time for us to QA this.

Face value though, looking good 👍

dominikwilkowski
dominikwilkowski reviewed Feb 28, 2019
View reviewed changes
@mikey0000
Copy link
Author

mikey0000 commented Feb 28, 2019

Thanks, will go over suggestions and tidy up.

dominikwilkowski
dominikwilkowski reviewed Feb 28, 2019
View reviewed changes
dominikwilkowski
dominikwilkowski reviewed Feb 28, 2019
View reviewed changes
@mikey0000 mikey0000 force-pushed the feature/pancake-svg-enhancement branch 2 times, most recently from 0f663cb to a5ca6bb Compare February 28, 2019 21:20
mikey0000
mikey0000 commented Feb 28, 2019
View reviewed changes
packages/pancake-svg/src/svg.js
import fs from 'fs';
import SVGSpriter from 'svg-sprite';
import { from as svgToImgFrom } from 'svg-to-img';
import {promisify} from 'util';
Copy link
Author

@mikey0000 mikey0000 Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is available since node v8

@azerella azerella changed the title Feature/pancake svg enhancement pancake-svg package enhancement Feb 28, 2019
@azerella azerella force-pushed the develop branch 5 times, most recently from f7e15ef to 6ae703e Compare March 25, 2019 02:33
@azerella azerella changed the title pancake-svg package enhancement [WIP] pancake-svg package enhancement May 1, 2019
@azerella
Copy link
Contributor

azerella commented May 3, 2019

@mikey0000 Sorry it's taken us so long to get back to this issue, just wanted to let you know the current status. We're going to put this PR on hold until we make a firm decision on the future of the pancake tooling, we are currently looking at some alternatives but maybe isolate the sass dependency functionality.

If we do decide to keep pancake though, this PR is going to be our first priority!

@mikey0000
Copy link
Author

mikey0000 commented May 3, 2019

No worries, good to hear.

@mikey0000 mikey0000 force-pushed the feature/pancake-svg-enhancement branch from 58cc1c2 to 5033660 Compare November 13, 2019 02:40
@mikey0000 mikey0000 changed the base branch from develop to master November 13, 2019 02:46
@mikey0000 mikey0000 force-pushed the feature/pancake-svg-enhancement branch from faaa524 to 5033660 Compare November 13, 2019 21:40
Update babelrc to correctly translate to latest node version and use …
ff40ddb 
…fs.readFileSync so spriter doesn't compile nothing
@mikey0000 mikey0000 force-pushed the feature/pancake-svg-enhancement branch from e6ac536 to ff40ddb Compare November 26, 2019 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dominikwilkowski dominikwilkowski dominikwilkowski left review comments

@azerella azerella azerella left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@mikey0000 mikey0000

Labels

enhancement New feature or request. module: pancake-svg An issue or pull request related to pancake-svg.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikey0000 @azerella @dominikwilkowski