Open
Conversation
Collaborator
|
Please squash this pull into a single commit, with a message in the format listed here |
Author
|
@shcarrico Thank you for your review. I just wonder why the commit message format should be applied? Other PR didn't be composed with the format. |
Collaborator
|
@shcarrico you should be able to squash all commits into one during the merge. There is a feature in github that would allow you to squash a PR. https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Druid has various filters and
infilter is one of them. Usinginfilters, template or variable separated by comma can be used as query parameter. The value is transformed to array.I referred to In Filter from this document(http://druid.io/docs/latest/querying/filters.html).
infilter, template or variable can be used to queryinfilter, value which are separated by comma can be used to query