ci: fast Java formatting check using google-java-format native binary#1227
Open
zeitlinger wants to merge 2 commits intomainfrom
Open
ci: fast Java formatting check using google-java-format native binary#1227zeitlinger wants to merge 2 commits intomainfrom
zeitlinger wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates local Java linting to be fast and scoped to changed files by using the google-java-format native binary (while keeping Gradle Spotless as the authoritative CI check).
Changes:
- Add
ubi:google/google-java-formatas a pinned mise tool. - Replace the Gradle-based Spotless lint task with a
lint:javatask that checks only changed.javafiles and validates SPDX headers. - Update
fixto format changed Java files viagoogle-java-formatbefore running the full lint suite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zeitlinger
changed the title
Replaces the slow Gradle-based spotlessCheck in the lint:java mise task with google-java-format native binary (~42ms for changed files). Also checks license headers. CI still runs the full spotlessCheck via Gradle.
zeitlinger
force-pushed
the
native-lint-java
branch
from
b482661 to
fecfa36
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jaydeluca
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spotlessCheckin thelint:spotlessmise task withgoogle-java-formatnative binary (lint:java)origin/main), runs in ~42ms instead of minutesspotlessCheckvia Gradle as the authoritative checkubi:google/google-java-formatas a mise tool (Renovate will keep it current)Test plan
mise run lint:javapasses with no changed Java filesmise run lint:javadetects formatting issues and missing license headersmise run fixauto-formats changed Java files