Use GATs in DataService
#89
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow users to use `&self` in closures or generators when iterating over the queries in the request, for example. Previously all closures/async blocks would have needed to own their data but now we can express to the compiler that `Self` will outlive the output stream :tada:
This is a bit of a tradeoff: users may need to clone aspects of the request if they want to use it for every query in request.queries(), since the futures they return need to outlive the request (and so must own the parts they need). It does mean that users have ownership of the request again though... is that needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
DataService::Streamassociated type generic over a lifetime bound bySelf. This means users can borrow data fromselfin their implementations even if they reference it in the futures of their stream. TBC whether this is actually worth doing 🤷