feat(commonlib): Move style choices to design tokens dir #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making eaier to manage those choices and override those in the future in one place.
Remove misleading thresholds from grafana by default
Dasomeone
reviewed
Nov 20, 2025
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
This is a fantastic effort @v-zhuravlev! Works great too, tested with the kafka observ-lib locally, and worked just fine and added additional palette info to a couple panels.
One comment on consistent naming on colours, what gets aliases and what doesn't, but overall hugely in favour of this.
| + timeSeries.standardOptions.color.withMode('fixed') | ||
| + timeSeries.standardOptions.color.withFixedColor('light-purple'), | ||
| + timeSeries.standardOptions.color.withMode(tokens.base.colors.mode.single) | ||
| + timeSeries.standardOptions.color.withFixedColor(tokens.base.colors.palette['light-purple']), |
Member
There was a problem hiding this comment.
Given that this particular colour has an alias for rate but nor for topk_percentage, perhaps we should settle on a consistent approach here?
Contributor
Author
There was a problem hiding this comment.
wdyt, what should be done here?
Dasomeone
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making easier to manage those choices and override those in the future in one place.
In other words, all things like colors or line thickness are placed in in folder, and then referenced by commonlib panels (or observ-libs that uses common-lib as a core). So if it decided to change base colors used it just one place where to change it.
Refs
https://www.uxpin.com/studio/blog/what-are-design-tokens/
Meantime, this is not a breaking change, everything should work as before.