Skip to content

feat: opentelemetry-collector-observ-lib#1610

Open
theSuess wants to merge 1 commit intomasterfrom
otelcol-observ-lib
Open

feat: opentelemetry-collector-observ-lib#1610
theSuess wants to merge 1 commit intomasterfrom
otelcol-observ-lib

Conversation

@theSuess
Copy link
Contributor

This PR adds a new observ-lib for the OpenTelemetry internal metrics.

Screenshot of the overview dashboard:
image

@cla-assistant
Copy link

cla-assistant bot commented Mar 18, 2026

CLA assistant check
All committers have signed the CLA.

@theSuess theSuess force-pushed the otelcol-observ-lib branch 2 times, most recently from 593f34f to dc61f5a Compare March 18, 2026 14:15
@theSuess theSuess force-pushed the otelcol-observ-lib branch from dc61f5a to 6e44c3a Compare March 18, 2026 15:02
"defaults": {
"color": {
"fixedColor": "text",
"fixedColor": "#5794f2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH not sure where the diff in this file is coming from. My changes shouldn't casue this but needed to regenerate the dashboard for CI to pass

@theSuess theSuess marked this pull request as ready for review March 19, 2026 08:52
@theSuess theSuess requested a review from a team as a code owner March 19, 2026 08:52
@cyrille-leclerc
Copy link

It's great!
Nothing blocking in this feedback.

Additional question: do we plan to add Loki logs?

image

@theSuess
Copy link
Contributor Author

I'll elaborate on some decisions mentioned in the feedback:

  • The reason behind breaking down processors by component is that it doesn't make sense to aggregate them as chains of processors lead to sums that aren't useful. For receiving and exporting, the aggregation is a useful statistic
  • Good catch on the Service_instance_id and job field. I was working based on the singals lib which is a bit biased towards prometheus. Will fix this to use service_name instead of job (same value, gets mapped by the otel endpoint)
  • People will use the dashboard outside of k8s as well so it's not included specifically anywhere. I'll look into adding the host name as we'll have that information in most situations

Which other KPIs would you consider important for the collectors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants