Skip to content

promql: Update error message when using disabled PromQL experimental aggregation function #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

promql: Update error message when using disabled PromQL experimental aggregation function #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion promql/parser/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ func (p *parser) newAggregateExpr(op Item, modifier, args Node) (ret *AggregateE
if !EnableExperimentalFunctions && ret.Op.IsExperimentalAggregator() {
// In mimir we return a custom message which doesn't mention the CLI flag that should be used to enable
// experimental functions, given it's different (and in SaaS customers don't even have access to it).
p.addParseErrf(ret.PositionRange(), "limitk() and limit_ratio() functions are not enabled")
p.addParseErrf(ret.PositionRange(), `function %q is not enabled`, ret.Op)
return
}
desiredArgs = 2
Expand Down
Loading