remove global name validation #892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
f9c5913 to
e0e77cf
Compare
ywwg
reviewed
Jun 17, 2025
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
e0e77cf to
8092852
Compare
aknuds1
reviewed
Jun 20, 2025
There was a problem hiding this comment.
Instead of pkg/util/validation.IsValidLabelName and pkg/util/validation.IsValidMetricName, I think a more forward looking solution would be to implement a method pkg/util/validation.Overrides.NameValidationScheme(tenantID string) validation.NamingScheme, and use that wherever you need to validate metric or label names. It can hard-code the legacy scheme, so we don't make it configurable at first. If we have such a solution, we can easily implement the next step, which is per-tenant configurability of metric/label name validation scheme.
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
31aff3b to
2ceae43
Compare
6 tasks
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
af1fe5f to
0f47658
Compare
aknuds1
reviewed
Jun 30, 2025
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
0f47658 to
ef1d8b1
Compare
…ng and query evaluation
…t, textparse, labels.
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
ef1d8b1 to
c0349fd
Compare
|
Superseded by #946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces explicit APIs to set validation scheme for various components of prometheus.
Uses / Depends on: