Skip to content

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Sep 27, 2022

Signed-off-by: Furkan [email protected]

What this PR does

Also adds missing errcheck linter since we already have a errcheckexclude file in the root.

Previous PR: grafana/cortex-tools#237

$ go run cmd/mimirtool/main.go remote-read stats --address http://10.11.12.13:30090 --selector '{__name__!=""}'

INFO[0000] Created remote read client using endpoint 'http://10.11.12.13:30090/prometheus/api/v1/read'
INFO[0000] Querying time from=2022-09-27T08:48:54+03:00 to=2022-09-27T09:48:54+03:00 with selector={__name__!=""}
main: error: remote server http://10.11.12.13:30090/prometheus/api/v1/read returned HTTP status 404 Not Found: 404 page not found, try --help
exit status 1

Which issue(s) this PR fixes or relates to

Fixes grafana/cortex-tools#236

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

cc @aknuds1

@Dentrax Dentrax requested a review from a team as a code owner September 27, 2022 06:47
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first pass, I see two changes that shouldn't be part of the PR.

@Dentrax
Copy link
Contributor Author

Dentrax commented Sep 27, 2022

@aknuds1 Accidentally closed, can you please re-open? 🙏

@aknuds1
Copy link
Contributor

aknuds1 commented Sep 27, 2022

The Reopen button is disabled for me, saying the branch was force-pushed or recreated.

@Dentrax Dentrax changed the title fix(remote-read): return err instead of nil [MOVED] fix(remote-read): return err instead of nil Sep 27, 2022
@Dentrax
Copy link
Contributor Author

Dentrax commented Sep 27, 2022

Oh, opened a new one: #3053 (Resolved your reviews!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prometheus: better resiliency: consider add --continue-on-error

3 participants