PPL Language Support part 2 #772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
iwysiu and
njvrzm
and removed request for
a team
15 tasks
kevinwcyu
approved these changes
Sep 4, 2025
|
|
||
| export const joinQuery = { | ||
| query: | ||
| 'left outer join left = table1 right = table2 left_hint.id = leftIdent on isnull(leftIdent) = false right = table2', |
There was a problem hiding this comment.
is left supposed to be suggested? when i type left i don't get that as a suggestion, it also isn't followed by outer as a suggestion.
There was a problem hiding this comment.
I left that out of the suggestions cause I thought it could be confusing bundling it with the commands. But it makes sense to suggest outer and join after left/right, will add that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds language (syntax highlighting and suggestions) support for the remainder of PPL commands:
joinCommand