Skip to content

chore(sigil): tighten HTTP metric routing helpers#601

Open
cyriltovena wants to merge 1 commit intomainfrom
chore/http-metrics-routing-cleanup
Open

chore(sigil): tighten HTTP metric routing helpers#601
cyriltovena wants to merge 1 commit intomainfrom
chore/http-metrics-routing-cleanup

Conversation

@cyriltovena
Copy link
Collaborator

@cyriltovena cyriltovena commented Mar 20, 2026 •
edited
Loading

Summary

  • factor query route detection into a dedicated helper in metricRequestArea
  • keep HTTP metric area classification behavior the same while reducing duplicated prefix checks
  • add table-driven coverage for metricRouteLabel, metricStatusClass, and isFeedbackPath

Testing

  • go test ./sigil/internal -run 'TestMetric(RouteLabel|StatusClass|RequestArea)|TestIsFeedbackPath' -count=1
  • go test ./sigil/internal -count=1

@cyriltovena
chore(sigil): tighten HTTP metric routing helpers
b8de5af 
Refactor metricRequestArea to use a dedicated query-route helper so route classification logic is easier to read and maintain without behavior changes.

Expand unit tests to cover route label trimming, status-class mapping, and feedback path detection so helper behavior stays locked during future cleanup work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cyriltovena