feat: Update libbinaryen v117 for [email protected] and ocaml 5 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
force-pushed
the
v117_1_0
branch
from
01d2926 to
5a1bdc4
Compare
ospencer
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of
v117fixing the issues we are seeing here in binaryen.ml. Most of this pr is just backporting the changes on main with the specific fix forv117being the-Wno-stringop-overreadchange in thedunefile.The original v117 was released quite a while and in that time a lot of things packages deprecated so we had to update all of our github actions dependencies this switched the gcc version used in our test suite causing the failures when we went to update binaryen.ml, we also need to update some of the packages used as opam deprecated a ton of packages.
The current plan is to keep this up as a branch and link binaryen.ml to the unreleased package rather than the npm package as this isn't really an issue with libbinaryen as much as it is with the build envrionment.
This also switches our actions test from macos-latest (15) to macos-14 as the clang 17 upgrade was causing some additional issues that couldn't be easily overridden.
Binaryen.ml update branch here: https://github.com/spotandjake/binaryen.ml/tree/spotandjake-117