Skip to content

(chore): update golangci-lint ver#664

Merged
pavelnikolov merged 1 commit intomasterfrom
update-golangci-lint-ver
May 24, 2025
Merged

(chore): update golangci-lint ver#664
pavelnikolov merged 1 commit intomasterfrom
update-golangci-lint-ver

Conversation

@pavelnikolov
Copy link
Member

Update golangci-lint to latest version

@pavelnikolov pavelnikolov requested a review from Copilot May 24, 2025 11:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project’s golangci-lint tool to v2.1.6 and applies related formatting changes across the codebase.

  • Bumps linter version in CI (.semaphore/semaphore.yml)
  • Migrates .golangci.yml to the v2 schema and adjusts linters/formatters
  • Applies automated style fixes (grouped type/var blocks, import reordering, ReplaceAll, flattened fields, etc.)
  • Adapts resolver code to use promoted fields and simplified references

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

File Description
.semaphore/semaphore.yml Install golangci-lint v2.1.6 in CI
.golangci.yml Switch to version 2 config; restructure linters/formatters
trace/tracer/tracer.go Grouped type aliases into a single type block
internal/schema/schema.go Use promoted fields (s.Present, s.Loc, s.Desc)
Comments suppressed due to low confidence (2)

.golangci.yml:17

  • Verify that "default: none" is valid for disabling all linters in golangci-lint v2; if not, use "disable-all: true" for clarity and consistency.
  default: none

internal/exec/resolvable/resolvable.go:315

  • [nitpick] This function signature is very long and exceeds typical line length conventions; consider breaking parameters onto multiple lines for improved readability.
func (b *execBuilder) makeObjectExec(typeName string, fields ast.FieldsDefinition, possibleTypes []*ast.ObjectTypeDefinition, interfaces []*ast.InterfaceTypeDefinition, nonNull bool, resolverType reflect.Type) (*Object, error) {

- fieldalignment
- deepequalerrors # remove later
formatters:
enable:
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider enabling the gofumpt linter under "linters.enable" to enforce stricter formatting rules alongside the formatters configuration.

Copilot uses AI. Check for mistakes.
@pavelnikolov pavelnikolov merged commit 4a5a501 into master May 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant