Skip to content

fix(app): background color #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

fix(app): background color #7079

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2d30b3
fix: background color being dual black tones
n1ru4l Oct 7, 2025
33e8c87
changeset
n1ru4l Oct 7, 2025
f427fac
:shrug:
n1ru4l Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-lands-take.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'hive': patch
---

Fix dashboard background using different shades of black.
2 changes: 1 addition & 1 deletion packages/web/app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<script src="/__env.js"></script>
</head>
<body>
<div class="bg-transparent font-sans text-white" id="root"></div>
<div class="font-sans text-white" id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
19 changes: 0 additions & 19 deletions packages/web/app/src/components/not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import ghost from '../../public/images/figures/ghost.svg?url';
import { Helmet } from 'react-helmet-async';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we no longer want the helmet functionality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't see a difference with and without it, so I removed it 😄

import { Button } from '@/components/ui/button';
import { captureMessage } from '@sentry/react';
import { useRouter } from '@tanstack/react-router';
Expand All @@ -25,24 +24,6 @@ export function NotFound() {
<Button variant="secondary" onClick={router.history.back}>
Go back
</Button>

<Helmet>
<style key="not-found-styles">
{`
html {
background:
url(/images/bg-top-shine.svg) no-repeat left top,
url(/images/bg-bottom-shine.svg) no-repeat right bottom,
#0b0d11;
}

body {
background: transparent !important;
color: #fcfcfc !important;
}
`}
</style>
</Helmet>
</div>
</>
);
Expand Down
8 changes: 6 additions & 2 deletions packages/web/app/src/components/ui/page-content-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,12 @@ type PageLayoutContentProps = {
const PageLayoutContent = forwardRef<HTMLDivElement, PageLayoutContentProps>(
({ children, mainTitlePage, ...props }, ref) => (
<div ref={ref} className={cn('grow', props.className)} {...props}>
<h1 className="mb-2 text-2xl font-semibold">{mainTitlePage}</h1>
{mainTitlePage ? <div className="mb-3 h-[1px] w-full bg-gray-700" /> : null}
{mainTitlePage ? (
<>
<h1 className="mb-2 text-2xl font-semibold">{mainTitlePage}</h1>
<div className="mb-3 h-[1px] w-full bg-gray-700" />
</>
) : null}
{children}
</div>
),
Expand Down
4 changes: 4 additions & 0 deletions packages/web/app/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,3 +203,7 @@
.hive-badge-is-changed:after {
@apply absolute right-2 size-1.5 rounded-full border border-orange-600 bg-orange-400 content-[''];
}

#root > * {
background-color: rgb(3 7 17 / var(--tw-bg-opacity, 1)) !important;
}
Comment on lines +206 to +213
Copy link
Contributor Author

@n1ru4l n1ru4l Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background color is a global style that is applied to body, but somehow does not cascade to the react app root containers children...

Loading