Skip to content

Test for toConfig #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Test for toConfig #1683

wants to merge 3 commits into from

Conversation

doniyor2109
Copy link

@doniyor2109 doniyor2109 commented Jan 22, 2019 •
edited
Loading

PR for #1674

  • GraphQLScalarType
  • GraphQLObjectType
  • GraphQLInterfaceType
  • GraphQLUnionType
  • GraphQLEnumType
  • GraphQLInputObjectType
  • GraphQLDirective
  • GraphQLSchema

IvanGoncharov
IvanGoncharov reviewed Jan 22, 2019
View reviewed changes
@IvanGoncharov IvanGoncharov added this to the v14.2.0 milestone Feb 5, 2019
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Feb 5, 2019
@IvanGoncharov IvanGoncharov removed this from the v14.x.x milestone Aug 13, 2020
Base automatically changed from master to main January 27, 2021 11:10
@IvanGoncharov IvanGoncharov modified the milestones: 16.0.0-alpha.1, post-16.0.0 Aug 22, 2021
@yaacovCR yaacovCR mentioned this pull request Oct 11, 2024
Merged
yaacovCR added a commit that referenced this pull request Oct 11, 2024
@yaacovCR
add toConfig tests (#4225)
ace6727 
would address #1679 

I think a simpler version than #1683
@yaacovCR
Copy link
Contributor

Thanks for submitting this!
This has (finally) been addressed in a slightly different way by #4225

@yaacovCR yaacovCR closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov left review comments

+1 more reviewer

@Sitinadia7 Sitinadia7 Sitinadia7 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
post-16.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@doniyor2109 @yaacovCR @IvanGoncharov @ryangueraa @Sitinadia7 @facebook-github-bot