Skip to content

polish(ast): prefer undefined over empty arrays #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

polish(ast): prefer undefined over empty arrays #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
513edb4
prefer undefined over empty arrays
yaacovCR Sep 28, 2024
125c2b7
use the change in this PR to close 2203
yaacovCR Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/execution/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,6 @@ export function validateExecutionArgs(
return [new GraphQLError('Must provide an operation.')];
}

// FIXME: https://github.com/graphql/graphql-js/issues/2203
/* c8 ignore next */
const variableDefinitions = operation.variableDefinitions ?? [];
const hideSuggestions = args.hideSuggestions ?? false;

Expand Down
2 changes: 0 additions & 2 deletions src/execution/values.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ export function experimentalGetArgumentValues(
): { [argument: string]: unknown } {
const coercedValues: { [argument: string]: unknown } = {};

// FIXME: https://github.com/graphql/graphql-js/issues/2203
/* c8 ignore next */
const argumentNodes = node.arguments ?? [];
const argNodeMap = new Map(argumentNodes.map((arg) => [arg.name.value, arg]));

Expand Down
26 changes: 13 additions & 13 deletions src/language/__tests__/parser-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ describe('Parser', () => {
loc: { start: 0, end: 40 },
operation: 'query',
name: undefined,
variableDefinitions: [],
directives: [],
variableDefinitions: undefined,
directives: undefined,
selectionSet: {
kind: Kind.SELECTION_SET,
loc: { start: 0, end: 40 },
Expand Down Expand Up @@ -290,7 +290,7 @@ describe('Parser', () => {
loc: { start: 9, end: 14 },
},
],
directives: [],
directives: undefined,
selectionSet: {
kind: Kind.SELECTION_SET,
loc: { start: 16, end: 38 },
Expand All @@ -304,8 +304,8 @@ describe('Parser', () => {
loc: { start: 22, end: 24 },
value: 'id',
},
arguments: [],
directives: [],
arguments: undefined,
directives: undefined,
selectionSet: undefined,
},
{
Expand All @@ -317,8 +317,8 @@ describe('Parser', () => {
loc: { start: 30, end: 34 },
value: 'name',
},
arguments: [],
directives: [],
arguments: undefined,
directives: undefined,
selectionSet: undefined,
},
],
Expand Down Expand Up @@ -349,8 +349,8 @@ describe('Parser', () => {
loc: { start: 0, end: 29 },
operation: 'query',
name: undefined,
variableDefinitions: [],
directives: [],
variableDefinitions: undefined,
directives: undefined,
selectionSet: {
kind: Kind.SELECTION_SET,
loc: { start: 6, end: 29 },
Expand All @@ -364,8 +364,8 @@ describe('Parser', () => {
loc: { start: 10, end: 14 },
value: 'node',
},
arguments: [],
directives: [],
arguments: undefined,
directives: undefined,
selectionSet: {
kind: Kind.SELECTION_SET,
loc: { start: 15, end: 27 },
Expand All @@ -379,8 +379,8 @@ describe('Parser', () => {
loc: { start: 21, end: 23 },
value: 'id',
},
arguments: [],
directives: [],
arguments: undefined,
directives: undefined,
selectionSet: undefined,
},
],
Expand Down
Loading
Loading