-
Notifications
You must be signed in to change notification settings - Fork 2k
use enableDevMode()
or development condition instead of NODE_ENV
#4464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
thanks @JoviDeCroock! (not sure what I did wrong before)
use latest dev mode with dual build (see graphql/graphql-js#4464) removes need for babel or swc
use just config setting: testEnvironment / customExportConditions use latest dev mode with dual build (see graphql/graphql-js#4464) no need for additional transformer
use just config setting: testEnvironment / customExportConditions use latest dev mode with dual build (see graphql/graphql-js#4464) no need for additional transformer
use just config setting: testEnvironment / customExportConditions use latest dev mode with dual build (see graphql/graphql-js#4464) no need for additional transformer
- use jest config setting: testEnvironment / customExportConditions - use latest dev mode with dual build (see graphql/graphql-js#4464) - no need for additional transformer
updated integration tests thanks to @JoviDeCroock offline help, jest test working (demonstrated also at: apollographql/apollo-server#8137) in terms of allowing switching back to prod mode, I still cannot reverse performance degradation in offline benchmarking even after 100,000 invocations of prod function, so will leave this simply as |
extracted from / based on:
Motivation:
This makes our build product cross-platform by dropping all Node.js specific code.
Differences:
import 'graphql/dev'
to enable development mode on platforms that do not support setting custom conditions, while this PR uses:import { enableDevMode } from 'graphql'; enableDevMode()
From the docs included in this PR: