-
Notifications
You must be signed in to change notification settings - Fork 90
feat: specific content-type filter for logging by API #13855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @michel-barret, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature for content-type based filtering in API logging, providing more granular control over data capture. Concurrently, it refactors the associated Angular UI components for improved maintainability and modernizes several backend Java code sections by adopting newer language constructs and cleaning up redundant code. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature to allow overriding content-type validation for logging, and includes significant code cleanup and modernization across the codebase. The Java code has been nicely refactored to use modern language features like switch expressions and pattern matching, improving readability. The frontend code is also updated to use strongly-typed Angular forms. I've found one issue in the frontend component where a refactoring introduced a bug that could affect UI behavior. My detailed feedback is in the comment below.
...anagement/api/reporter-settings/reporter-settings-proxy/reporter-settings-proxy.component.ts
Outdated
Show resolved
Hide resolved
956d934 to
853205c
Compare
b000621 to
116d6c8
Compare
...tee-apim-gateway-core/src/main/java/io/gravitee/gateway/core/logging/utils/LoggingUtils.java
Outdated
Show resolved
Hide resolved
...ateway-core/src/main/java/io/gravitee/gateway/reactive/core/v4/analytics/LoggingContext.java
Outdated
Show resolved
Hide resolved
cc0765c to
ca892f3
Compare
8a9865c to
227146d
Compare
Allow APIs to log setup custom Content-Type filter https://gravitee.atlassian.net/browse/APIM-11603
227146d to
474fd17
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-11603
Description
A small description of what you did in that PR.
Additional context