Skip to content

Conversation

@michel-barret
Copy link
Contributor

Issue

https://gravitee.atlassian.net/browse/APIM-11603

Description

A small description of what you did in that PR.

Additional context

@michel-barret michel-barret requested a review from a team as a code owner October 28, 2025 13:55
@michel-barret michel-barret marked this pull request as draft October 28, 2025 13:55
@gemini-code-assist
Copy link

Summary of Changes

Hello @michel-barret, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature for content-type based filtering in API logging, providing more granular control over data capture. Concurrently, it refactors the associated Angular UI components for improved maintainability and modernizes several backend Java code sections by adopting newer language constructs and cleaning up redundant code.

Highlights

  • New Content-Type Filtering for Logging: Introduced a new overrideContentTypeValidation field in the logging configuration, allowing users to specify a regular expression to filter out specific content types from being logged. This enhances control over sensitive or oversized data in API logs.
  • Angular Form Refactoring: The ReporterSettingsProxyComponent in the web UI has been refactored to use modern Angular FormControl and FormGroup types, replacing UntypedFormControl and UntypedFormGroup. This includes generalizing form control management with dedicated arrays for boolean and string configuration keys, improving maintainability.
  • Java Code Modernization and Cleanup: Various Java files have been updated to leverage modern language features such as switch expressions for cleaner type checking and getFirst() for list access. This also includes removal of unused imports and minor regex corrections, contributing to overall code quality and readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature to allow overriding content-type validation for logging, and includes significant code cleanup and modernization across the codebase. The Java code has been nicely refactored to use modern language features like switch expressions and pattern matching, improving readability. The frontend code is also updated to use strongly-typed Angular forms. I've found one issue in the frontend component where a refactoring introduced a bug that could affect UI behavior. My detailed feedback is in the comment below.

@michel-barret michel-barret force-pushed the mba-apim-11603 branch 4 times, most recently from 956d934 to 853205c Compare October 29, 2025 08:21
@michel-barret michel-barret changed the title chore: some clean up feat: specific content-type filter for logging by API Oct 29, 2025
@michel-barret michel-barret force-pushed the mba-apim-11603 branch 2 times, most recently from b000621 to 116d6c8 Compare October 29, 2025 11:07
@michel-barret michel-barret marked this pull request as ready for review October 29, 2025 11:07
@michel-barret michel-barret force-pushed the mba-apim-11603 branch 14 times, most recently from 8a9865c to 227146d Compare November 5, 2025 09:16
@michel-barret michel-barret merged commit 166c154 into master Nov 12, 2025
39 checks passed
@michel-barret michel-barret deleted the mba-apim-11603 branch November 12, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants