-
Notifications
You must be signed in to change notification settings - Fork 90
fix: correct query parsing for parentheses and AND/OR logic for filter logs #13911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct query parsing for parentheses and AND/OR logic for filter logs #13911
Conversation
Summary of ChangesHello @ankita-gupta21, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue in the log filtering mechanism by refining how complex queries involving parentheses and Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
8bcc251 to
732e574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively fixes the query parsing for filters involving parentheses and complex AND/OR logic. The changes in logs-filters.controller.ts correctly handle the aggregation of filter values, and the defensive array flattening in search-and-select.controller.ts enhances the component's robustness. I've noted a potential issue in the filter value parsing that could lead to incorrect behavior, and I've also suggested a performance optimization for array handling. Please see my detailed comments below.
gravitee-apim-console-webui/src/components/logs/logs-filters.controller.ts
Outdated
Show resolved
Hide resolved
...tee-apim-console-webui/src/components/logs/search-and-select/search-and-select.controller.ts
Outdated
Show resolved
Hide resolved
7796643 to
eb1cdf9
Compare
185efa8 to
3c9b6f6
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-11728
Description
Fixes decodeQueryFilters to properly handle parentheses and maintain correct AND/OR precedence when parsing filter queries.
Additional context
Fixes parsing of queries like:
Before Fix
APIM-11728_Before-fix.mov
After Fix
Screen.Recording.2025-11-04.at.10.25.25.AM.mov