-
Notifications
You must be signed in to change notification settings - Fork 30
fix: subpath patterns in exports
#666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Preview is ready. |
| "require": { | ||
| "types": "./build/cjs/extensions/*", | ||
| "default": "./build/cjs/extensions/*" | ||
| "types": "./build/cjs/extensions/*/index.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! We’ve reviewed the pull request and have a couple of suggestions:
- We recommend using absolute paths to the
indexfile in all extensions fromadditional. - The same applies to the
viewfolder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example:
"./extensions/Mermaid": {
"default": "./build/cjs/extensions/additional/Mermaid/index.js",
},
"./view/mermaid": {
"default": "./build/cjs/view/mermaid.js", // here exports all things related to diplodoc/mermaid-extension in src/view
},
|
@ogonkov is it still actual? |
|
I think yes, i will make changes that we discuss later |
|
Visual Tests Report is ready. |
Current exports seems dosn't work at all, looks like TS just guess path with old
moduleResolution, and fail to resolve anything with newmoduleResolution: bundlerTrace of resolution with node10 resolution