Open
Conversation
Collaborator
|
@d3m1d0v I suggest using negative margin for the first element and padding for the container
|
7b31530 to
46e48ed
Compare
46e48ed to
62cb200
Compare
makhnatkin
approved these changes
Feb 13, 2026
|
|
||
| export type YfmTableDnDDemoProps = { | ||
| lineWrapping: 'disabled' | 'enabled'; | ||
| lineNumbers: 'disabled' | 'enabled' | 'by-default'; |
Collaborator
There was a problem hiding this comment.
In my opinion, by-default looks unconventional as an enum value. Maybe rename it to default or auto?
| this.contentDOM = document.createElement('div'); | ||
|
|
||
| const hasLineWrapping = hasLineWrappingDecoration(decorations); | ||
| if (this._opts.lineNumbers?.enabled && hasLineWrapping) { |
Collaborator
There was a problem hiding this comment.
I’m not fully sure why hasLineWrapping is needed here, and why it isn’t needed in update() for _applyLineNumbersResult:
if (this._opts.lineNumbers?.enabled) {
this._applyLineNumbersResult = applyLineNumbers(
...
Could you clarify the reasoning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changes in CodeBlock:
Toolbar:
Also added a new example story where you can configure a code block.