feat: initDumps -> removed deprecated dumpsPath #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default for dumpsFilePath Default is formed as testInfo.titlePath with some alternations Removed slugs from initDumps. If user want to include slug in dumps file path, he must override dumpsFilePath manually
Avol-V
reviewed
Nov 27, 2025
| * @returns string path to dump file | ||
| */ | ||
| dumpsFilePath?: (params: { testInfo: TestInfo; slug: string; zip: boolean }) => string; | ||
| dumpsFilePath?: (params: { testInfo: TestInfo; zip: boolean }) => string; |
There was a problem hiding this comment.
Slug is a part of this package and I think we should provide an implementation of the path builder similar to the previous one, with slug. Something like dumpsPathWithSlugBuilder in a separate module. So users would be able to import it and use as a value for a dumpsFilePath during migration to this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default for dumpsFilePath
Default is formed as testInfo.titlePath with some alternations Removed slugs from initDumps. If user want to include slug in dumps file path, he must override dumpsFilePath manually