[FIX] upstream cached pages showing mobile for desktop pages#52
Open
alanjds wants to merge 1 commit intogregmuellegger:masterfrom
Open
[FIX] upstream cached pages showing mobile for desktop pages#52alanjds wants to merge 1 commit intogregmuellegger:masterfrom
alanjds wants to merge 1 commit intogregmuellegger:masterfrom
Conversation
Owner
|
Hey, that's a very useful addition. Thanks! |
Contributor
Author
|
Ouch... I appreciate projects with tests, but I have no experience on coding Unittests, just Doctests. I can do it, but waiting for me will take some time. |
Owner
|
Ok, don't hesitate to ask questions if you don't get along. :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got a client complaining about mobile pages showing up for desktop browsers. Turned up that he uses a Varnish-backed server, and django-mobile serves pages based on
User-AgentifMobileDetectionMiddlewareis used.It should set the
Vary: User-Agentheader.