Closed
Conversation
* Payment * OfferCreate * CheckCash * All AMM transactions * Pathfinding Retire FlowCross feature
Retire FlowSortStrands, fixQualityUpperBound, fix1515. Consolidate TOfferBase into TOffer (TOffer can be only inst with non-STAmount).
…and creditHook() into IOU/MPT functions. Retire RmSmallIncreasedQOffers. Extend FlowMPT and MPToken unit-tests.
Update testTrasnferFee tests. Fix args order compile error plus minor refactoring.
Simplify MPTEndpointStep. Change terNO_LINE to temBAD_PATH in MPTEndpointStep::check. Allow MPT error in validFwd.
Add src/dst issuer check to MPTEndpointStep. Remove lsfMPTCanTransfer | lsfMPTCanTrade flags from checkCreateMPT. Update PathMPT_test.
Fix individual freeze in pathfinder. Rename some vars and fix comments.
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com>
Replace checkMPTTxAllowed() with canMPTTradeAndTransfer().
gregtatcam
force-pushed
the
feature/mpt-v2e
branch
from
134721b to
198df6a
Compare
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change