Open
Conversation
grempe
requested changes
Jun 21, 2022
Owner
grempe
left a comment
grempe
left a comment
There was a problem hiding this comment.
Can you add some brief docs to the README to cover usage and motivation for this feature?
I left a note about a typo.
| - `id` (Erlang term()) name of the bucket | ||
| - `scale` (Integer) of time the bucket you want to inspect was created with. | ||
| - `limit` (Integer) representing the max counter size the bucket was created with. | ||
| - `new_remaining` (Integer) the new value for remaining, will replace current remaining iff it is less. |
Owner
There was a problem hiding this comment.
There's a typo in this line "iff"
There was a problem hiding this comment.
It might have been https://en.wikipedia.org/wiki/If_and_only_if
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have several systems, in our case one written in ruby and one in elixir both hitting the same api, they both count against the api's rate limit. In this case, our internal rate limit (maintained w/ ExRated) is occasionally very incorrect.
However, the api returns an x-ratelimit-remaining header. So, if we notice that the api's remaining is much lower than ExRated, we would like to simply use the api's. And we would like to do so atomically, such that, if the value that ExRated has for remaining is actually lower than what the API has, we want to use ExRated's version.
Changes:
decrease_remaining_topublic function to ExRated, which casts to the genserver